comparison mcabber/src/settings.c @ 774:46304b773a44

Remove useless checks before g_free() calls
author Mikael Berthe <mikael@lilotux.net>
date Sat, 25 Mar 2006 18:16:10 +0100
parents 4e15322d315e
children 1dd19363c73e
comparison
equal deleted inserted replaced
773:e25b8a348ebd 774:46304b773a44
163 // set *pkey and *pval (*pval is set to NULL if value field is empty). 163 // set *pkey and *pval (*pval is set to NULL if value field is empty).
164 // 164 //
165 // If this isn't a assignment (no = char), the function will set *pval 165 // If this isn't a assignment (no = char), the function will set *pval
166 // to NULL and return FALSE. 166 // to NULL and return FALSE.
167 // 167 //
168 // The called should g_free() *pkey and *pval (if not NULL) after use. 168 // The caller should g_free() *pkey and *pval (if not NULL) after use.
169 guint parse_assigment(gchar *assignment, const gchar **pkey, const gchar **pval) 169 guint parse_assigment(gchar *assignment, const gchar **pkey, const gchar **pval)
170 { 170 {
171 char *key, *val, *t, *p; 171 char *key, *val, *t, *p;
172 172
173 *pkey = *pval = NULL; 173 *pkey = *pval = NULL;
237 237
238 sptr = settings_find(*plist, key); 238 sptr = settings_find(*plist, key);
239 if (sptr) { 239 if (sptr) {
240 // The setting has been found. We will update it or delete it. 240 // The setting has been found. We will update it or delete it.
241 setting = (T_setting*)sptr->data; 241 setting = (T_setting*)sptr->data;
242 if (setting->value) 242 g_free(setting->value);
243 g_free(setting->value);
244 if (!value) { 243 if (!value) {
245 // Let's remove the setting 244 // Let's remove the setting
246 g_free(setting->name); 245 g_free(setting->name);
247 *plist = g_slist_delete_link(*plist, sptr); 246 *plist = g_slist_delete_link(*plist, sptr);
248 } else { 247 } else {