changeset 2290:71ec41732035

Fix small memory leak 'servername' was not freed (and jidtodisp() was unnecessary. (Spotted by franky)
author Mikael Berthe <mikael@lilotux.net>
date Wed, 21 Dec 2016 20:43:58 +0100
parents a63814f2e4c8
children 0d350e979bde
files mcabber/mcabber/xmpp_iq.c
diffstat 1 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/mcabber/mcabber/xmpp_iq.c	Wed Dec 21 20:30:56 2016 +0100
+++ b/mcabber/mcabber/xmpp_iq.c	Wed Dec 21 20:43:58 2016 +0100
@@ -585,15 +585,15 @@
   const gchar *from = lm_message_get_from(m);
 
   if (from) {
-    gchar *self_bjid = jidtodisp(lm_connection_get_jid(c));
-    gchar *servername = get_servername(self_bjid, "");
-    if ((!jid_equal(self_bjid, from)) &&
+    const gchar *self_jid = lm_connection_get_jid(c);
+    gchar *servername = get_servername(self_jid, "");
+    if ((!jid_equal(self_jid, from)) &&
        (!servername || strcasecmp(from, servername))) {
       scr_LogPrint(LPRINT_LOGNORM, "Received invalid roster IQ request");
-      g_free(self_bjid);
+      g_free(servername);
       return LM_HANDLER_RESULT_REMOVE_MESSAGE;
     }
-    g_free(self_bjid);
+    g_free(servername);
   }
 
   y = lm_message_node_find_child(lm_message_node_find_xmlns(m->node, NS_ROSTER),